Add sticky support in Query block #26279
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ntsekouras
added
[Feature] Full Site Editing
[Block] Query Loop
ntsekouras
requested review from
ajitbohra,
nerrad,
ntwb,
Soean and
talldan
as code owners
|
Size Change: +189 B (0%) Total Size: 1.2 MB
ℹ️ View Unchanged
|
|
As described over here there are three options:
(Locally tested.) The sticky option itself is a boolean – but using the option at all is another option, therefore we have 3 options and it’s definetely needed. If one wants to show “only sticky posts” in one Query Block, you need the option to exclude sticky posts in another Query Block to prevent duplicates. |
Hey @mariohamann - thanks for pointing this out! I pushed changes to handle all cases. |
ntsekouras
changed the title
|
I wonder if a better label for the first option would be "include sticky posts"? |
|
@scruffian The naming was my proposal, but I hadn't the label in mind when thinking about it (only thought about the options). In fact, you are absolutely right. What do you think about the following proposals to make it shorter and – in my opinion – more clear? OR |
|
I like both. I'd put |
|
@ntsekouras 👍🏻 Thanks for relabeling once more! |
ntsekouras
force-pushed
the
add/sticky-support-in-query
branch
4 times, most recently
from
b62573d to
34f5966
Compare
mtias
reviewed
Oct 23, 2020
mtias
approved these changes
Oct 23, 2020
aristath
approved these changes
Oct 23, 2020
ntsekouras
force-pushed
the
add/sticky-support-in-query
branch
2 times, most recently
from
96d2107 to
f58ed4d
Compare
ntsekouras
force-pushed
the
add/sticky-support-in-query
branch
from
f58ed4d to
84e3886
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Part of: #24934
This PR adds
stickysupport in theQueryblock. There are three options:Reference: https://developer.wordpress.org/rest-api/reference/posts/#arguments
Another not related thing this PR changes, is some whitespaces differences that occurred during the regeneration of fixtures. The regeneration tool uses
spacesand there were some handwritten withtabs.Checklist: